Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(directory): don't select more than 50 ontology items #4622

Merged
merged 11 commits into from
Jan 29, 2025

Conversation

MaxPostema
Copy link
Contributor

@MaxPostema MaxPostema commented Jan 21, 2025

fixes: #906

What are the main changes you did

  • selecting "Diagnosis available" is limited to 50 items
  • having 50 selected items shows a warning box to limit your selections
Scherm­afbeelding 2025-01-21 om 13 47 47

Todo

  • Limit selected items on switching any/all filter

How to test

  • select a root "Diagnosis available" filter, notice that only the first 50 are selected and a info box is shown

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

Copy link
Member

@esthervanenckevort esthervanenckevort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to only put this limitation only on 'Match all' queries, since the current implementation limits queries for any diagnosis in a certain block in ICD-10, which would still be a useful query to do.

There also is an inconsistency in how things work. If I select an entire block but that is more than fifty terms the user interface still shows the entire block as selected, but if I open the block I see that only part of them are selected. This leads to people thinking that they still searched the entire block. I think it is useful to make it visible in some way that not all of that block was selected next to the message at the top. At least it should only have the partial selection (-) symbol instead of the full selection (✓)

@connoratrug
Copy link
Contributor

please add an regression test

@MaxPostema MaxPostema merged commit 6bf27b1 into master Jan 29, 2025
6 of 7 checks passed
@MaxPostema MaxPostema deleted the fix/dont-select-lots-of-items-ontologyfilter branch January 29, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants